Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessibility warnings #45

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix accessibility warnings #45

merged 2 commits into from
Dec 12, 2023

Conversation

noclat
Copy link
Member

@noclat noclat commented Dec 12, 2023

  • Add aria-label on suggestions list (required by role="listbox").
  • Add format.suggestions ARIA label option.
  • Add aria-label on country mode open <label> (because it starts empty, then it's filled with the country name).
  • Add format.changeCountry ARIA label option.
  • Remove aria-hidden on <input type="checkbox" /> country mode switch because it's focusable.
  • Add aria-hidden to .pka-panel-country when country selector is disabled.
  • Add aria-label on SVG logo.

@noclat noclat merged commit 85d2ec4 into main Dec 12, 2023
1 check passed
@noclat noclat deleted the feat/a11y branch December 12, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant