Complete all methods #6
Conversation
dukenguyenxyz
commented
Mar 8, 2021
•
dukenguyenxyz
commented
- Use enums instead of strings
- Complete specs
| struct PutResponse < Base | ||
| getter header : Header | ||
| struct PutResponse < WithHeader | ||
| # Why is this nillable | ||
| getter prev_kv : Kv? |
There was a problem hiding this comment.
Nillable because the previous is only included if you ask for the previous kv.
There was a problem hiding this comment.
And it might not be present
There was a problem hiding this comment.
Theres no nillable type marking on the openapi specs, makes everything a bit more confusing than it should be
There was a problem hiding this comment.
I think you should work against the API rather than the spec. I remember it not being consistent.
src/etcd/auth.cr
Outdated
| end | ||
|
|
||
| private def validate!(name : String) | ||
| raise ArgumentError.new("Arg name is empty") if name.empty? |
There was a problem hiding this comment.
You can put an always inline annotation above this. That will inline the code (i.e. just drop the method inline in the method, reducing the overhead of a method call (i.e. setting up a stack)
The message is also a little vague. Something closer to the message below would be preferrable.
Argument `name` is empty.
caspiano
force-pushed
the
feat/update
branch
2 times, most recently
from
bd873e2 to
b43427e
Compare
Authored By: Duke Nguyen <[email protected]> Co-Authored By: Caspian Baska <[email protected]>
caspiano
force-pushed
the
feat/update
branch
from
b43427e to
e1974f0
Compare
