Adding support for macOS by using shims #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 8, 2017 16:07
This allows PKHUD to be used across iOS and macOS Note: WindowRootViewController has been dropped, as it is not used anymore.
On macOS showing a hud in a window sheet lead to black corners where the VisualEffectView should have transparent rounded corners
|
Thanks for this HUGE PR. I will give a try ASAP. |
|
some progress there? |
|
Not so many. I thinks it would be better to change the branch to feature/macOS and work there for the next release. |
|
closing, due to working in a feature branch where this (#141) PR tries to add the changes |
|
Thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds complete support for using PKHUD under macOS.
Changes are almost all additive and held simple by adding a shim file to bring both platform APIs together.
Use the demo app to check if all huds work smoothly and do what they say.
Then please check logic and code style and see if it all fits.