Handle additional unicodes #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhheider
approved these changes
Jan 5, 2025
There was a problem hiding this comment.
this is fine as it stands. I'd like to see a more general implementation. at a minimum, i'd like openssl to be handled the same way, and maybe libstdcxx/libcxx. but, more specifically:
Re: unicode: I suspect we should allow duplicates in the event of non-intersecting specs for all packages, with the highest version first in CPATH/LIBRARY_PATH and only the highest in PATH. But I haven't gamed out the downsides.
intersection issues are one of the worst problems we encounter in the pantry, and we're uniquely positioned to be able to solve them in this way.
|
I agree, though for this initial release I just want a direct port to make diagnosing port issues easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.