Add fix quality metadata and fixedFindings for changeset entry
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nahsra
approved these changes
Dec 4, 2024
gilday
approved these changes
Dec 6, 2024
| @@ -15,22 +16,33 @@ public final class CodeTFChangesetEntry { | |||
| private final List<CodeTFChange> changes; | |||
|
|
|||
| private final CodeTFAiMetadata ai; | |||
| private final Strategy strategy; | |||
| private final boolean provisional; | |||
There was a problem hiding this comment.
I think the spec already calls for this to be a boolean, so I'm probably too late on this feedback, but replacing "boolean" with "enum that has two items" leaves room for expansion and better describes what this is e.g.
enum Maturity { MATURE, PROVISIONAL; }There was a problem hiding this comment.
Noted, but at this point I think we will need to revisit it at a later date.
Comment on lines
+38
to
+39
| this.strategy = strategy; | ||
| this.provisional = provisional; | ||
| this.fixedFindings = CodeTFValidator.toImmutableCopyOrEmptyOnNull(fixedFindings); |
There was a problem hiding this comment.
I assume all of these may be null to allow for backwards compatibility, but do we expect to eventually make these required?
There was a problem hiding this comment.
I don't have a strong opinion about this. Provisional has a reasonable default of false but strategy does not.
drdavella
force-pushed
the
spec-update-metadata
branch
from
ad881f0 to
265ba8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.