Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixedFIndings at changeset level #42

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Add fixedFIndings at changeset level #42

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84678c2
Add fixedFindings field to ChangeSet
drdavella Dec 3, 2024
134d90b
Change change.findings => fixedFindings
drdavella Dec 3, 2024
e517770
Clarify description of changeset.fixedFindings
drdavella Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion codetf.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,11 @@
"provisional": {
"type": "boolean",
"description": "Indicates that the fix is provisional"
},
"fixedFindings": {
"type": "array",
"description": "List of findings that were fixed by this changeset",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an exhaustive list, right? It's all these finding, plus those in the changes (if any), right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, yes. I can improve the description.

"items": { "$ref": "#/definitions/detector/fixedFinding" }
}
},
"required": ["path", "diff", "changes"]
Expand Down Expand Up @@ -211,7 +216,7 @@
"description": "The package actions that were needed to support changes to the file",
"items": { "$ref": "#/definitions/packageAction" }
},
"findings": {
"fixedFindings": {
"type": "array",
"description": "List of findings that were fixed at this location",
"items": { "$ref": "#/definitions/detector/fixedFinding" }
Expand Down