Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🦺 Include Finding ID in CodeTF Only When Provided by the Tool #38

Merged
merged 1 commit into from
Aug 19, 2024
Merged

🦺 Include Finding ID in CodeTF Only When Provided by the Tool #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions codetf.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,22 +268,22 @@
"properties": {
"id": {
"type": "string",
"description": "A unique identifier for the finding (e.g. 'guid' from SARIF)"
"description": "A unique identifier for the finding, if provided by the detection tool. Concerning logically equivalent findings across scans, this identifier has the same semantics as `guid` from SARIF."
},
"rule": {
"$ref": "#/definitions/detector/rule",
"description": "The rule that detected the issue"
}
},
"additionalProperties": true,
"required": ["id", "rule"]
"required": ["rule"]
},
"unfixedFinding": {
"type": "object",
"properties": {
"id": {
"type": "string",
"description": "A unique identifier for the finding (e.g. 'guid' from SARIF)"
"description": "A unique identifier for the finding, if provided by the detection tool. Concerning logically equivalent findings across scans, this identifier has the same semantics as `guid` from SARIF."
},
"rule": {
"$ref": "#/definitions/detector/rule",
Expand All @@ -303,7 +303,7 @@
}
},
"additionalProperties": true,
"required": ["id", "rule", "path", "reason"]
"required": ["rule", "path", "reason"]
},
"rule": {
"type": "object",
Expand Down