Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor new combined Sonar flag #489

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Honor new combined Sonar flag #489

merged 5 commits into from
Jan 9, 2025

Conversation

nahsra
Copy link
Contributor

@nahsra nahsra commented Jan 9, 2025

@nahsra nahsra requested a review from drdavella January 9, 2025 03:31
drdavella
drdavella approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@drdavella drdavella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this is a breaking change since the old flags are no longer supported.

@nahsra nahsra enabled auto-merge (squash) January 9, 2025 14:04
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nahsra nahsra merged commit 37de8c3 into main Jan 9, 2025
8 checks passed
@nahsra nahsra deleted the honor_merged_sonar_format branch January 9, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdoyal bdoyal bdoyal approved these changes

@drdavella drdavella drdavella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nahsra @drdavella @bdoyal