-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added option to set Navigation icon colors in camera.js, using buttons and font-awsome.css #9
base: master
Are you sure you want to change the base?
Conversation
Hi Mike, thank you... at the moment I'm very busy, I hope to take a look to your Manuel :-) 2012/5/21 Mike Sozanski <
Manuel Masia – Pixedelic http://www.pixedelic.com |
Is it possible to see something in action? |
Here is a sample page using "magenta": http://macosxsupport.com/camera/ I added the option to have the background of the pagination circles also use the buttonColor setting, but I think it would be better to have the selected "dot" be the color rather than the background in the future. (The javascript is all in camera.js) Note: This example has an icon in the caption for a Lightbox popup, not part of my pull request, just a feature I wanted to add for a gallery. |
think i prefer sprites |
Hi Manuel, Thanks for your Camera plugin. I have one issue and one suggestion. Looking forward for the next release with fixes. Muralikrishna P |
OK, bear with me since this is my first pull request and I am a jQuery novice!
I love your slider but didn't like the limitations of using images for navigation UI.
Rather than have the navigation icons use a sprite and CSS for skin colors, I added an option to be able to set the icon colors in camera.js. By changing the next, prev, play and stop as well as the thumb_next, thumb_prev to use icons from font-awsome.css, https://github.com/FortAwesome/Font-Awesome, and some button CSS code from Twitter bootstrap, https://github.com/twitter/bootstrap, one can set these icons to any color as a setting in Camera, "buttonColor".
Still some bugs ( it seems that if there are two sliders on a page, the colors are the same for both!)
Mike