Fix handling of whitespaces in common_set_list function #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the common_set_list is not used yet in the current version of easycwmp data model. But it could be used in the future, and you are right if the list contains a value that contains spaces then it will be treated in wrong way. But your suggestion does not meet the issue, I really do not understand how your modif can fix the issue, please review your suggestion |
|
The fix changes the internal field separator to |
If the payload contains whitespaces (for example openvpn remote parameter), the common_set_list function splits the payload at these whitespaces. This commit fixes this issue.
okraits
force-pushed
the
tdt-fix-common_set_list
branch
from
8bcabef to
7ac1358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the payload contains whitespaces (for example openvpn remote parameter),
the common_set_list function splits the payload at these whitespaces. This
commit fixes this issue.