forked from apache/arrow
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft hash_pivot API #12
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitrou
added a commit
that referenced
this pull request
Dec 19, 2024
…n timezone (apache#45051) ### Rationale for this change If the timezone database is present on the system, but does not contain a timezone referenced in a ORC file, the ORC reader will crash with an uncaught C++ exception. This can happen for example on Ubuntu 24.04 where some timezone aliases have been removed from the main `tzdata` package to a `tzdata-legacy` package. If `tzdata-legacy` is not installed, trying to read a ORC file that references e.g. the "US/Pacific" timezone would crash. Here is a backtrace excerpt: ``` #12 0x00007f1a3ce23a55 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6 #13 0x00007f1a3ce39391 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6 apache#14 0x00007f1a3f4accc4 in orc::loadTZDB(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#15 0x00007f1a3f4ad392 in std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#2}::_FUN() () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#16 0x00007f1a4298bec3 in __pthread_once_slow (once_control=0xa5ca7c8, init_routine=0x7f1a3ce69420 <__once_proxy>) at ./nptl/pthread_once.c:116 apache#17 0x00007f1a3f4a9ad0 in orc::LazyTimezone::getEpoch() const () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#18 0x00007f1a3f4e76b1 in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#19 0x00007f1a3f4e84ad in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#20 0x00007f1a3f4e8dd7 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#21 0x00007f1a3f4e8532 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#22 0x00007f1a3f4925e9 in orc::RowReaderImpl::startNextStripe() () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#23 0x00007f1a3f492c9d in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 apache#24 0x00007f1a3e6b251f in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900 ``` ### What changes are included in this PR? Catch C++ exceptions when iterating ORC batches instead of letting them slip through. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * GitHub Issue: apache#40633 Authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
… pytest (apache#45240) ### Rationale for this change pytest-cython 0.3.1 was releases with the fix required for our tests to pass. ### What changes are included in this PR? Remove unnecessary dependency pinned versions. ### Are these changes tested? Via existing CI ### Are there any user-facing changes? No * GitHub Issue: apache#45239 * GitHub Issue: apache#41002 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…wheel upload (apache#45222) ### Rationale for this change The upload wasn't failing with the empty, non existent dir. ### What changes are included in this PR? - Fix the path - Prevent the upload from failing silently when no wheels are found ### Are these changes tested? crossbow ### Are there any user-facing changes? no * GitHub Issue: apache#45155 Lead-authored-by: Jacob Wujciak-Jens <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…harp (apache#45241) Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 3.0.0 to 3.0.1. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/f8675c32e51818b13f1314569ec35b62246999c3"><code>f8675c3</code></a> v3.0.1</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/b7d67bac0f6616a5ba3594f5d365f0c858424172"><code>b7d67ba</code></a> Missed passing an argument</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/8cbe1c39a625685c65f2f4bf50b406c3ee60bbf3"><code>8cbe1c3</code></a> Restore VisualStudioSourceInformationProvider for <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/433">#433</a></li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/d71328f59375d09e5e5ced6e82909146793250a1"><code>d71328f</code></a> Updated xunit.runner.json schema URL</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/a320aa3caf4f854fbc300a9a7cac2bf2a7d02a97"><code>a320aa3</code></a> Latest dependencies (to fix <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/432">#432</a>)</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/5382a589cd50dee962e3690330dea96808c761f9"><code>5382a58</code></a> Move SpyLoggerHelper into the global namespace</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/8f3a5861cf95b76519998d9f9703ff4ade59f092"><code>8f3a586</code></a> <a href="https://redirect.github.com/xunit/visualstudio.xunit/issues/431">#431</a>: ValueTask defined in xunit.runner.visualstudio causing conflict</li> <li><a href="https://github.com/xunit/visualstudio.xunit/commit/0a250fc23147fe9f64d6b4dc61a46685429ee1bf"><code>0a250fc</code></a> Bump up to 3.0.1-pre</li> <li>See full diff in <a href="https://github.com/xunit/visualstudio.xunit/compare/3.0.0...3.0.1">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xunit.runner.visualstudio&package-manager=nuget&previous-version=3.0.0&new-version=3.0.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Curt Hagenlocher <[email protected]>
…45242) Bumps [Grpc.Tools](https://github.com/grpc/grpc) from 2.68.1 to 2.69.0. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/grpc/grpc/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=Grpc.Tools&package-manager=nuget&previous-version=2.68.1&new-version=2.69.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Curt Hagenlocher <[email protected]>
…#45244) [//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [Google.Protobuf](https://github.com/protocolbuffers/protobuf) and System.Memory. These dependencies needed to be updated together. Updates `Google.Protobuf` from 3.29.2 to 3.29.3 <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/protocolbuffers/protobuf/commit/b407e8416e3893036aee5af9a12bd9b6a0e2b2e6"><code>b407e84</code></a> Updating version.json and repo version numbers to: 29.3</li> <li><a href="https://github.com/protocolbuffers/protobuf/commit/9a5d2c329c159e07f7da8ba5dfe0acc98dfb81a9"><code>9a5d2c3</code></a> Add .bazeliskrc for protobuf repo to tell bazelisk to use 7.1.2 by default. (...</li> <li><a href="https://github.com/protocolbuffers/protobuf/commit/1dc5842ebe7956e79d5dfee6d3589df02faa77fd"><code>1dc5842</code></a> Fix cmake installation location of java and go features (<a href="https://redirect.github.com/protocolbuffers/protobuf/issues/19773">#19773</a>)</li> <li><a href="https://github.com/protocolbuffers/protobuf/commit/8e7e6b026f0ef00fd0f3d3cbeb41a02f8621c785"><code>8e7e6b0</code></a> Update artifact actions to v4 (<a href="https://redirect.github.com/protocolbuffers/protobuf/issues/19703">#19703</a>)</li> <li><a href="https://github.com/protocolbuffers/protobuf/commit/cbdc8ab774aeb888f635a1f3d0bce206e173b276"><code>cbdc8ab</code></a> Merge pull request <a href="https://redirect.github.com/protocolbuffers/protobuf/issues/19719">#19719</a> from protocolbuffers/29.x-202412181411</li> <li><a href="https://github.com/protocolbuffers/protobuf/commit/5621748f97259be36587bf337aae554f6361cb22"><code>5621748</code></a> Updating version.json and repo version numbers to: 29.3-dev</li> <li>See full diff in <a href="https://github.com/protocolbuffers/protobuf/compare/v3.29.2...v3.29.3">compare view</a></li> </ul> </details> <br /> Updates `System.Memory` from 4.6.0 to 4.5.3 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Curt Hagenlocher <[email protected]>
Bumps [xunit](https://github.com/xunit/xunit) from 2.9.2 to 2.9.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/xunit/xunit/commit/9712244020d385955d33136b3fe3e87de43539cd"><code>9712244</code></a> v2.9.3</li> <li><a href="https://github.com/xunit/xunit/commit/dbba909f1b7922a4d254c9d064a8f1458d996325"><code>dbba909</code></a> <a href="https://redirect.github.com/xunit/xunit/issues/3088">#3088</a>: Assert.Equivalent throws NotSupportedException for types with getters ...</li> <li><a href="https://github.com/xunit/xunit/commit/cdf2114812a6312c4c0b1ca182a1fe6a65692422"><code>cdf2114</code></a> Stick to .NET SDK 8</li> <li><a href="https://github.com/xunit/xunit/commit/5716c89078aa82bdd11892cdcc1b1b66cbcbb9b5"><code>5716c89</code></a> Disable NETSDK1215 and NU1902 for .NET 9 SDK</li> <li><a href="https://github.com/xunit/xunit/commit/607007022f26cf524a7e7b350ed8f1b08b73796b"><code>6070070</code></a> TeamCity Reporter. Remove flow id from name of test suites. (<a href="https://redirect.github.com/xunit/xunit/issues/3054">#3054</a>)</li> <li><a href="https://github.com/xunit/xunit/commit/bfd42e0ed5c7fc177e871a438da6cd27fe09a2ed"><code>bfd42e0</code></a> <a href="https://redirect.github.com/xunit/xunit/issues/3053">#3053</a>: Class data derived from TheoryData<SomeType[]> is broken</li> <li><a href="https://github.com/xunit/xunit/commit/5f7494f7fdfe3e1307e9ce5b84acb64abacb0df7"><code>5f7494f</code></a> Update assertions and tests</li> <li><a href="https://github.com/xunit/xunit/commit/3f9460dec39560e97e97d708fc98377f3bff53eb"><code>3f9460d</code></a> Updated README</li> <li><a href="https://github.com/xunit/xunit/commit/d1206d9a6a922e1aaceb1f6587548461b06c318d"><code>d1206d9</code></a> Update README</li> <li><a href="https://github.com/xunit/xunit/commit/dc5dd04ac3dce21b647044972198e399bcbd152c"><code>dc5dd04</code></a> Bump up to v2.9.3-pre</li> <li>See full diff in <a href="https://github.com/xunit/xunit/compare/v2-2.9.2...v2-2.9.3">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=xunit&package-manager=nuget&previous-version=2.9.2&new-version=2.9.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Lead-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Curt Hagenlocher <[email protected]> Signed-off-by: Curt Hagenlocher <[email protected]>
…gQueue (apache#45221) ### Rationale for this change SequencingQueue and SerialSequencingQueue are useful in creating custom ExecNodes. This patch allows linking to factory functions. ### What changes are included in this PR? ARROW_ACERO_EXPORT classes ### Are there any user-facing changes? Users can now directly instantiate and use the SequencingQueue and SerialSequencingQueue classes, enabling easier creation of custom ExecNode. * GitHub Issue: apache#45215 Authored-by: kamilt <[email protected]> Signed-off-by: Rossi Sun <[email protected]>
### Rationale for this change Apache ORC has just released 2.1.0: https://orc.apache.org/news/2025/01/09/ORC-2.1.0/ We need to upgrade it to avoid occasional download failures of orc-format. ### What changes are included in this PR? Bump Apache ORC to its latest version 2.1.0. ### Are these changes tested? Pass CIs. ### Are there any user-facing changes? No. * GitHub Issue: apache#45225 Lead-authored-by: Gang Wu <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Gang Wu <[email protected]>
…he#45223) ### Rationale for this change `replace_with_mask` should link to the section containing it. ### What changes are included in this PR? `replace_with_mask` links to the section containing it. ### Are these changes tested? No. ### Are there any user-facing changes? Yes, but only in the docs. No code is changed. Authored-by: Dan King <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
…45245) Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.5.0 to 4.6.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v4.6.0</h2> <h2>What's Changed</h2> <ul> <li>Expose env vars to control concurrency and timeout by <a href="https://github.com/yacaovsnc"><code>@yacaovsnc</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/662">actions/upload-artifact#662</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4...v4.6.0">https://github.com/actions/upload-artifact/compare/v4...v4.6.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/actions/upload-artifact/commit/65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08"><code>65c4c4a</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/662">#662</a> from actions/yacaovsnc/add_variable_for_concurrency_a...</li> <li><a href="https://github.com/actions/upload-artifact/commit/020761922861c5b0a0a9b98ae4adccf1f675862c"><code>0207619</code></a> move files back to satisfy licensed ci</li> <li><a href="https://github.com/actions/upload-artifact/commit/1ecca81102de35b6c140e930a09ea6144c27abf1"><code>1ecca81</code></a> licensed cache updates</li> <li><a href="https://github.com/actions/upload-artifact/commit/97422693d3a0493fc2d725fe8c0ac1c1097e9128"><code>9742269</code></a> Expose env vars to controll concurrency and timeout</li> <li>See full diff in <a href="https://github.com/actions/upload-artifact/compare/6f51ac03b9356f520e9adb1b1b7802705f340c2b...65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.5.0&new-version=4.6.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@ dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@ dependabot rebase` will rebase this PR - `@ dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@ dependabot merge` will merge this PR after your CI passes on it - `@ dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@ dependabot cancel merge` will cancel a previously requested merge and block automerging - `@ dependabot reopen` will reopen this PR if it is closed - `@ dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@ dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@ dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@ dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Jacob Wujciak-Jens <[email protected]>
…le merge (apache#45255) ### Rationale for this change See apache#45254 ### What changes are included in this PR? First modify the test case to expose the suspecting bug. Then the fix in source. ### Are these changes tested? By existing tests. ### Are there any user-facing changes? None. * GitHub Issue: apache#45254 Authored-by: Rossi Sun <[email protected]> Signed-off-by: Rossi Sun <[email protected]>
pitrou
force-pushed
the
pivot_kernel
branch
2 times, most recently
from
January 14, 2025 19:20
6bc1ee7
to
78abf09
Compare
…#45256) ### Rationale for this change Laurent Goujon became a committer on November. No requirement to be specified as collaborator anymore. Announcement here: https://lists.apache.org/thread/jj7z0hvjbr6y2m4xjwv78s9ptvbhsc78 ### What changes are included in this PR? Remove laurentgo from list of collaborators as is a committer now. ### Are these changes tested? No ### Are there any user-facing changes? No Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
) ### Rationale for this change The pr aims to correct an error in doc `Columnar.rst` ### What changes are included in this PR? Obviously, the value of `Length` below is incorrect, it should be `5`. <img width="775" alt="image" src="https://github.com/user-attachments/assets/9e53d415-0a6e-4d2b-9822-9eb20456898a" /> ### Are these changes tested? No, only for docs. ### Are there any user-facing changes? Reduce misunderstandings among end users. Authored-by: panbingkun <[email protected]> Signed-off-by: mwish <[email protected]>
pitrou
force-pushed
the
pivot_kernel
branch
2 times, most recently
from
January 15, 2025 12:58
e0b2382
to
c053794
Compare
…r in `parquet::arrow::FileWriter::NewRowGroup()` (apache#45088) ### Rationale for this change Just noticed that the implementation doesn't use the parameter. ### What changes are included in this PR? Remove the parameter from `NewRowGroup()` ### Are these changes tested? ### Are there any user-facing changes? The `chunk_size` parameter is now deprecated. * GitHub Issue: apache#45048 Lead-authored-by: Krisztian Szucs <[email protected]> Co-authored-by: Raúl Cumplido <[email protected]> Co-authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Raúl Cumplido <[email protected]>
…rmutation` and `scatter` (apache#44394) ### Rationale for this change For background please see apache#44393. When implementing the "scatter" function requested in apache#44393, I found it also useful to make it a public vector API. After a painful thinking, I decided to name it "permute". And when implementing permute, I found it fairly easy to implement it by first computing the "reverse indices" of the positions, and then invoking the existing "take", where I think "reverse_indices" itself can also be a useful public vector API. Thus the PR categorized them as "placement functions". ### What changes are included in this PR? Implement vector selection API `inverse_permutation` and `scatter`, where `scatter(values, indices)` is implemented as `take(values, inverse_permutation(indices))`. ### Are these changes tested? UT included. ### Are there any user-facing changes? Yes, new public APIs added. Documents updated. * GitHub Issue: apache#44393 Lead-authored-by: Ruoxi Sun <[email protected]> Co-authored-by: Rossi Sun <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?