Parameterize LdaModel variational magic numbers #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the VAR_MAXITER and VAR_THRESH constants from LdaModel and allows each to be set when a new model is made, or during a call to update(). They have been named iterations and gamma_threshold. Logging messages for the number of passes were changed to use the word "pass" instead of "iteration", to avoid any confusion. Other logging messages were also updated to include these vars. This is a non-automatic fix for Issue #58.
|
Looks good, thanks Christopher! It's not a fix for #58 -- that one is about automatically setting optimal values, based on actual training data. |
piskvorky
added a commit
that referenced
this pull request
Mar 2, 2014
Parameterize LdaModel variational magic numbers
|
Yep. I was going to attempt setting optimal values, but it seems that some of my test documents do not converge after 10,000 iterations (yikes). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the VAR_MAXITER and VAR_THRESH constants from
LdaModel and allows each to be set when a new model is made, or
during a call to update(). They have been named iterations and
gamma_threshold.
Logging messages for the number of passes were changed to use the word
"pass" instead of "iteration", to avoid any confusion. Other logging
messages were also updated to include these vars.
This is a non-automatic fix for Issue #58.