Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to ProtobufFrameSerializer to send the transport messages #1270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added support to ProtobufFrameSerializer to send the transport messages #1270

wants to merge 1 commit into from
+40 −6

Conversation

filipi87
Copy link
Contributor

Added support to ProtobufFrameSerializer to send the messages from TransportMessageFrame and TransportMessageUrgentFrame.

@codecov Codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pipecat/frames/protobufs/frames_pb2.py 44.44% 5 Missing ⚠️
src/pipecat/serializers/protobuf.py 83.33% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/pipecat/serializers/protobuf.py 88.52% <83.33%> (-0.57%) ⬇️
src/pipecat/frames/protobufs/frames_pb2.py 52.17% <44.44%> (-0.46%) ⬇️

@filipi87
Added support to ProtobufFrameSerializer to send the messages from …
e321063 
…`TransportMessageFrame` and `TransportMessageUrgentFrame`.
@filipi87 filipi87 force-pushed the improve_protobuf_serializer branch from a30c7d8 to e321063 Compare February 21, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aconchillo aconchillo Awaiting requested review from aconchillo

@markbackman markbackman Awaiting requested review from markbackman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@filipi87