Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for werkzeuge 3.0.0 #291

Closed
wants to merge 1 commit into from
Closed

Conversation

attrib
Copy link

@attrib attrib commented Oct 13, 2023

With the latest release of werkzeuge 3.0.0 snappass doesn't work anymore.

Traceback (most recent call last):
  File "/usr/local/bin/snappass", line 33, in <module>
    sys.exit(load_entry_point('snappass==1.6.0', 'console_scripts', 'snappass')())
  File "/usr/local/bin/snappass", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/local/lib/python3.8/importlib/metadata.py", line 77, in load
    module = import_module(match.group('module'))
  File "/usr/local/lib/python3.8/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1014, in _gcd_import
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/local/lib/python3.8/site-packages/snappass-1.6.0-py3.8.egg/snappass/main.py", line 10, in <module>
    from werkzeug.urls import url_quote_plus
ImportError: cannot import name 'url_quote_plus' from 'werkzeug.urls' (/usr/local/lib/python3.8/site-packages/werkzeug-3.0.0-py3.8.egg/werkzeug/urls.py)

This fixes the usage of the removed functions as recommeded from the deprecation message - https://github.com/pallets/werkzeug/blob/2.3.x/src/werkzeug/urls.py#L643

@vin01
Copy link
Contributor

vin01 commented Nov 20, 2023

this should help #300

@yurushao
Copy link
Contributor

yurushao commented Jan 3, 2024

Thanks for the PR. We've merged #300 for the same purpose.

@yurushao yurushao closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants