Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add peer review system for queries #1535

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

zhangvi7
Copy link
Contributor

@zhangvi7 zhangvi7 commented Jan 30, 2025

Context

This update introduces a Query Review System to Querybook, which enhances the security of query executions by ensuring that important and sensitive queries can be reviewed by peers before they are executed.

Changes

  • Peer review request modal: Request a new review
  • Review panel: View all reviews
  • Reviewer View: Approve/Reject a query in a Query Execution view
  • DB Migration: query_review
  • New Plugins: query_review_handler_plugin and notification_templates_plugin
  • Notification logic: On approve, reject, request review
  • Misc: review endpoint, redux updates, public config changes, frontend changes

TODO:

  • Websocket changes to update review updates on UI
  • Documentation
  • Ability to copy paste review link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant