fix: update schedule disabler configs #1414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: update schedule disabler configs
jczhong84
reviewed
Feb 25, 2024
Comment on lines
+120
to
+125
| if disable_config.skip_if_no_impression_with_export: | ||
| task_have_export = len(task_dict["kwargs"].get("exports", [])) > 0 | ||
| if task_have_export: | ||
| return False | ||
|
|
||
| if not disable_config.skip_if_no_impression_but_non_select: | ||
| if disable_config.skip_if_no_impression_but_non_select: |
There was a problem hiding this comment.
@czgu could you help to look at this? I'm a bit confused about the actual meaning of these two configs. should it disable or not when they are true.
skip_if_no_impression_with_export
skip_if_no_impression_but_non_select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip_if_no_impression_with_exportandskip_if_no_impression_but_non_selectto match the semantic meaning of these options. "Skip disabling the datadoc if it has no impression but has an exporter", and "Skip disabling the datadoc if it has no impression but there are non-select queries"Previously, creating this task looked like this:
View of creating the task now with kwarg options
