Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify binary Jar using R8 #2347

Closed
wants to merge 1 commit into from

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Nov 9, 2023

Description

We can minify binary Jar size significantly by R8, which is the default code shrinker of Android.

https://r8.googlesource.com/r8#d8-dexer-and-r8-shrinker

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

@Goooler
Copy link
Contributor Author

Goooler commented Nov 9, 2023

Tests failed, need to add more keep rules, some of them are related to picocli.CommandLine, will investigate it later.

@paul-dingemans
Copy link
Collaborator

@Goooler I will close this PR for now. Feel free to reopen when you know how to proceed.

@Goooler Goooler deleted the minify-fatjar-with-r8 branch March 2, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants