-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sink(ticdc): fix incorrect default
field (#12038)
#12052
base: release-8.1
Are you sure you want to change the base?
sink(ticdc): fix incorrect default
field (#12038)
#12052
Conversation
Signed-off-by: ti-chi-bot <[email protected]>
This cherry pick PR is for a release branch and has not yet been approved by triage owners. To merge this cherry pick:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@wk989898 This PR has conflicts, I have hold it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.1 #12052 +/- ##
================================================
Coverage ? 57.2631%
================================================
Files ? 854
Lines ? 126577
Branches ? 0
================================================
Hits ? 72482
Misses ? 48651
Partials ? 5444 |
/unhold |
/retest-required |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wk989898 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #12038
What problem does this PR solve?
Issue Number: close #12037
What is changed and how it works?
OriginDefaultValue
is used as the column value when the default value is invisible.It should not be used as the
default
field.Affected protocol
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note