Merge pull request #883 from raybellis/main

fix hue errors in plasma_stick_rainbows
pimoroni · Jan 16, 2024 · 0d3fce9 · 0d3fce9
2 parents bff2453 + da0ac18
commit 0d3fce9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/examples/plasma_stick/plasma_stick_rainbows.cpp b/examples/plasma_stick/plasma_stick_rainbows.cpp
@@ -34,10 +34,15 @@ int main() {
   while(true) {
 
     offset += float(SPEED) / 2000.0f;
+    if (offset > 1.0) {
+      offset -= 1.0;
+    }
 
     for(auto i = 0u; i < NUM_LEDS; ++i) {
       float hue = float(i) / NUM_LEDS;
-      led_strip.set_hsv(i, hue + offset, 1.0f, 1.0f);
+      hue += offset;
+      hue -= floor(hue);
+      led_strip.set_hsv(i, hue, 1.0f, 1.0f);
     }
 
     sleep_ms(1000 / UPDATES);

diff --git a/micropython/examples/plasma_stick/rainbows.py b/micropython/examples/plasma_stick/rainbows.py
@@ -28,9 +28,10 @@
 
     SPEED = min(255, max(1, SPEED))
     offset += float(SPEED) / 2000.0
+    offset %= 1
 
     for i in range(NUM_LEDS):
-        hue = float(i) / NUM_LEDS
+        hue = (offset + float(i) / NUM_LEDS) % 1
         led_strip.set_hsv(i, hue + offset, 1.0, 1.0)
 
     time.sleep(1.0 / UPDATES)