-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gotenberg option generateDocumentOutline to $options array #92
base: 1.x
Are you sure you want to change the base?
Add Gotenberg option generateDocumentOutline to $options array #92
Conversation
Thank you for the contribution! Unfortunately, this PR cannot be merged as is, this See also |
Quality Gate passedIssues Measures |
@kingjia90 thank you for checking! I did not realise the exception for Maybe a |
]; | ||
|
||
foreach ($options as $option) { | ||
if (isset($params[$option]) && $params[$option] != false) { | ||
if (isset($params[$option]) && $params[$option] != false && method_exists($chromium, $option)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe let's move generateDocumentOutline
outside the $options
array and have a standalone IF block for it with a comment on the fact that on v1 it's not supported, it would be easier to remember for future clean up when for example dropping support to v1 and to avoid checking methodExists on the ones that are surely true
This should allow creating a document outline based on the HTML heading structure in the PDF file