chore: add pnpm and yarn lockfile to gitignore to allow contributors to use different package managers #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use different package managers
wesleytodd
requested changes
Nov 26, 2024
There was a problem hiding this comment.
I am quite opposed to this. The behaviors of the package managers are VERY different (I can cite sources if you like) and this can lead some undesirable outcomes from a maintenance perspective. I have been meaning to actually bring this up but have not yet had time, but I would like us to adopt the devEngines spec and annotate that we use npm and latest LTS node for development on these packages.
All this said, I would love to hear if other folks had opinions on this to help us fill out our strategy in this area.
gatleas17
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.