Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing duplicated methods #904

Merged
merged 7 commits into from
Oct 27, 2024
+39 −598
Merged

Fixing duplicated methods #904

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3cb9659
Removing errorType, isWhat and isAbstract duplicated methods
Ducasse Oct 27, 2024
76d1381
Removing duplicated protocolNames and LatexPathUpdateSnippet isAbstract
Ducasse Oct 27, 2024
319c7d7
hasAnchor is duplicated
Ducasse Oct 27, 2024
cd990de
inlineParserClass duplicate removal
Ducasse Oct 27, 2024
33d767c
Fixing bunch of tests
Ducasse Oct 27, 2024
046ed17
Removing duplicated method in MicLaTeXWriterTest
Ducasse Oct 27, 2024
86f9c17
Fixing richText tests (unclear to me)
Ducasse Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microdown-BookTester/MicAnchorResult.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Class {
{ #category : 'kinds' }
MicAnchorResult class >> errorType [

^ 'UndefinedAnchor'
^ 'Anchor problem'
]

{ #category : 'accessing' }
Expand All @@ -36,7 +36,7 @@ MicAnchorResult >> explanation [

{ #category : 'accessing' }
MicAnchorResult >> isWhat [
^ 'undefined'
^ 'anchor problem'
]

{ #category : 'accessing' }
Expand Down
5 changes: 0 additions & 5 deletions src/Microdown-Evaluator/MicCompilationContext.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@ MicCompilationContext class >> configuration: aConfiguration [
^ self new configuration: aConfiguration
]

{ #category : 'instance creation' }
MicCompilationContext class >> isAbstract [
^ false
]

{ #category : 'instance creation' }
MicCompilationContext class >> withDocument: aDocument [
^ self new
Expand Down
15 changes: 6 additions & 9 deletions src/Microdown-LaTeXExporter-Tests/MicAbstractLaTexWriterTest.class.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ Class {
}

{ #category : 'asserting' }
MicAbstractLaTexWriterTest class >> shouldInheritSelectors [
MicAbstractLaTexWriterTest class >> isAbstract [

^ true
]

Expand Down Expand Up @@ -65,9 +66,10 @@ MicAbstractLaTexWriterTest >> factory: aFactory [

{ #category : 'accessing' }
MicAbstractLaTexWriterTest >> newLine: aNewLine [
(aNewLine = String cr) ifTrue:[ writer crAsNewLine ].
(aNewLine = String lf) ifTrue:[ writer lfAsNewLine ].
(aNewLine = String crlf) ifTrue:[ writer crlfAsNewLine ].

aNewLine = String cr ifTrue: [ writer crAsNewLine ].
aNewLine = String lf ifTrue: [ writer lfAsNewLine ].
aNewLine = String crlf ifTrue: [ writer crlfAsNewLine ].
newLine := aNewLine
]

Expand Down Expand Up @@ -689,8 +691,3 @@ MicAbstractLaTexWriterTest >> writeForElement: aNode [
writer visit: aNode.

]

{ #category : 'accessing' }
MicAbstractLaTexWriterTest >> writer: aWriter [
writer := aWriter new
]
Loading
Loading