File parser #744
Merged
File parser #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fused kids a bit more robust .
…s added to the root properties , delete it
Ducasse
reviewed
May 21, 2024
| @@ -0,0 +1,30 @@ | |||
| Class { | |||
| #name : 'FileParser', | |||
There was a problem hiding this comment.
Can you rename your class FromFileTest?
tx
Ducasse
reviewed
May 21, 2024
| Microdown >> parseFile: aFile [ | ||
|
|
||
| |root| | ||
| root := MicrodownParser parse:(aFile contents) . |
There was a problem hiding this comment.
parse: (aFile contents).
No extra space
Ducasse
reviewed
May 21, 2024
| ^ self propertyAt: #file . | ||
| ] | ||
|
|
||
| { #category : 'visiting' } |
Ducasse
reviewed
May 21, 2024
| @@ -32,6 +32,16 @@ MicRootBlock >> canConsumeLine: line [ | |||
| ^ true | |||
| ] | |||
|
|
|||
| { #category : 'visiting' } | |||
| MicRootBlock >> fromFile [ " retieve " | |||
| ^ self propertyAt: #file . | |||
There was a problem hiding this comment.
the last period is not needed.
|
I could not understand why the ParentChild code is in this PR. |
|
I will merge this PR but it was messy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file parser , read a file parse then its content with microdown parser and add the file to the properties of the root element .