add link and test in Web developpemment #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Salut quentin |
Ducasse
reviewed
May 16, 2024
| @@ -94,6 +94,153 @@ When you participate to the mooc you get access to the quizz and the credit vali | |||
| ^ file | |||
| ] | |||
|
|
|||
| { #category : 'as yet unclassified' } | |||
| MicSummarizerTest >> htmlBodyTest [ | |||
|
|
|||
There was a problem hiding this comment.
for the single summariser I do not get why we would have to have all the links.
Ducasse
reviewed
May 16, 2024
|
|
||
| | a q date header | | ||
| a := (MicHTMLVisitor new visit: aMicRoot) at: 1. | ||
|
|
There was a problem hiding this comment.
we can add on microroot something like
date
self children first date
MetaData >> date
....
with a default date if there is none in the metadata
this will probably only works when we have metadata so on MicElement we should define another
date
^ Date ....1980
Ducasse
reviewed
May 16, 2024
|
|
||
| destinationDirectory := aDestination | ||
| ] | ||
|
|
There was a problem hiding this comment.
indeed the summariser as well as all the components date sorter, blogentry...
should all work from a directory to a directory.
So I asked myself what is filePath vs. destinaryDirectory: why this is not a sourceDirectory
Ducasse
reviewed
May 16, 2024
| | headerLink | | ||
| headerLink := MicHeaderBlock new. | ||
| headerLink | ||
| addChild: |
There was a problem hiding this comment.
You can extract this expression in makeAlink: to:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a link for the header of file in HTML and for each date.
I had a ellipsis to paragraph block where there too long.