Fix slice encoding

[chrisroberts]

Encoding a field that is a slice will currently panic due to Elem() being called on a slice in util.ReflectValue. reflect.Value only allows for Elem() to be called on interface or pointer values and will panic otherwise. So this just removes slice from being included in the check to unwrap and adds in a test to validate that encoding the slice is successful.

[coveralls]

Pull Request Test Coverage Report for Build 9752982979

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 96.897%

---

Totals
Change from base Build 9298275274:	0.0%
Covered Lines:	406
Relevant Lines:	419

---

💛 - Coveralls

[pilagod]

@chrisroberts Nice catch! Could you help me to add an integration test in cursor/encoding_test.go, by encoding and then decoding to ensure they work expectedly?

You can take other cases as examples:

gorm-cursor-paginator/cursor/encoding_test.go

Lines 141 to 165 in 49dddd0

	/* struct */
	type structModel struct {
	Value structValue
	ValuePtr *structValue
	}
	type structValue struct {
	Value []byte
	}
	func (s *encodingSuite) TestStruct() {
	c, _ := s.encodeValue(structModel{
	Value: structValue{Value: []byte("123")},
	})
	v, _ := s.decodeValue(structModel{}, c)
	s.Equal(structValue{Value: []byte("123")}, v)
	}
	func (s *encodingSuite) TestStructPtr() {
	sv := structValue{Value: []byte("123")}
	c, _ := s.encodeValuePtr(structModel{ValuePtr: &sv})
	v, _ := s.decodeValuePtr(structModel{}, c)
	s.Equal(sv, *(v.(*structValue)))
	}

But I am wondering that []byte should be also a slice, right? I am not sure why the []byte case could work perfectly, do you have any idea?

[chrisroberts]

@pilagod Yeah, no problem. Added in the extra tests.

As for the []byte case, it works because the value on the struct is not the byte slice directly, rather the value is the struct that contains the byte slice. So when the value is reflected, it's not seen as a slice.

[coveralls]

Pull Request Test Coverage Report for Build 9765782179

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 96.897%

---

Totals
Change from base Build 9298275274:	0.0%
Covered Lines:	406
Relevant Lines:	419

---

💛 - Coveralls

[pilagod]

You're right, I totally missed it is under another struct.

Thank you so much for this patch, it looks pretty good to me. I will notify you once there is a new release including this fix 💪

[pilagod]

I just released v2.6.1 to include this patch. Thanks again for the contribution. 🙌

[chrisroberts]

Awesome, thank you so much @pilagod!