Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade clang + CUDA CI pipeline to use CUDA 12 #1366

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Dec 6, 2024

This should allow using C++20 again for both the spec and the build of pika. This also allows removing the +allow-unsupported-compilers variant.

@msimberg msimberg self-assigned this Dec 6, 2024
Copy link

codacy-production bot commented Dec 6, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.09% (target: -1.00%) (target: 90.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (11dfb31) 18223 13730 75.34%
Head commit (84ffb6c) 18223 (+0) 13714 (-16) 75.26% (-0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1366) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@msimberg
Copy link
Contributor Author

msimberg commented Dec 6, 2024

Well, now clang is old enough for CUDA to support, but CUDA is too new for clang to support. This may be causing errors. I'll come back to this once other CI PRs have settled a bit.

@msimberg msimberg force-pushed the clang-cuda-12-cxxstd-20 branch 6 times, most recently from 4a99635 to d393566 Compare January 14, 2025 12:33
@msimberg msimberg force-pushed the clang-cuda-12-cxxstd-20 branch 3 times, most recently from 7fafd33 to 95e2415 Compare January 27, 2025 11:35
@msimberg msimberg force-pushed the clang-cuda-12-cxxstd-20 branch from 95e2415 to 84ffb6c Compare January 27, 2025 13:52
@msimberg msimberg added this to the 0.32.0 milestone Jan 27, 2025
@msimberg msimberg marked this pull request as ready for review January 27, 2025 13:52
@msimberg msimberg enabled auto-merge January 27, 2025 13:53
@msimberg msimberg added this pull request to the merge queue Jan 27, 2025
Merged via the queue into pika-org:main with commit e349358 Jan 27, 2025
40 checks passed
@msimberg msimberg deleted the clang-cuda-12-cxxstd-20 branch January 27, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant