Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base image to ubuntu 23.10 (mantic) #44

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Update base image to ubuntu 23.10 (mantic) #44

merged 2 commits into from
Jan 30, 2024

Conversation

msimberg
Copy link
Contributor

@msimberg msimberg commented Jan 24, 2024

The HIP image still uses the old 22.04 base image.

@msimberg msimberg self-assigned this Jan 24, 2024
@msimberg msimberg changed the title Update base image to ubuntu 23.04 (mantic) Update base image to ubuntu 23.10 (mantic) Jan 24, 2024
@msimberg
Copy link
Contributor Author

Note, the branch name says 23.04, but 23.10 is what I intended. I'm not opening a new PR with a better branch name.

@msimberg msimberg force-pushed the ubuntu-23.04 branch 2 times, most recently from 77d41a5 to b28bd7c Compare January 29, 2024 15:40
Install dependencies from repositories whenever possible.
@msimberg msimberg requested a review from aurianer January 29, 2024 15:55
@msimberg msimberg marked this pull request as ready for review January 29, 2024 15:55
Copy link
Collaborator

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@aurianer aurianer merged commit c2bce39 into main Jan 30, 2024
1 check passed
@msimberg msimberg deleted the ubuntu-23.04 branch January 30, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants