added support for window.open in onCreateWindow (android) #1679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please approve this PR :) |
|
This feature is much needed, thanks! @pichillilorenzo |
|
Please merge this PR if everything is done. |
furkankurt
approved these changes
May 29, 2024
There was a problem hiding this comment.
LGTM 🚀 looking forward to you see and merging it @pichillilorenzo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
Resolve issue #1633
related to issue #755
Testing and Review Notes
Currently on Android, onCreateWindow's createWindowAction returns a null url if open.window() function is used.
createWindowAction will only return a non-null url for anchor tags with href specified.
Upon further inspection, it seems that webview's onCreateWindow couldn't retrieve url value if its not an anchor tag.
Hence I've proposed a support for open.window() flow, utilizing its HitTestResult type of unknown type. Aside from the additional logic if type is HitTestResult.UKNOWN_TYPE, this PR also updates the onCreateWindow parameters. isDialog and isUserGesture is made final so that inner class could access it.
Here's a gist to test the behavior of onCreateWindow Url:
https://gist.github.com/zopagaduanjr/b119f5f06d4d3af7bdcbb3b7f99b61ed
Screenshots or Videos
video demo
Screen.Recording.2023-06-01.at.1.48.43.AM.mov
onCreateWindow Urls
To Do