Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total CPU % to /info/system endpoint #2297

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

Add total CPU % to /info/system endpoint #2297

wants to merge 4 commits into from
+144 −11

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 27, 2025

What does this implement/fix?

Calculate and expose total CPU % for the web interface, see related PR.

Related issue or feature (if applicable): Related to pi-hole/web#3261

Pull request in docs with documentation (if applicable): N/A

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the API label Feb 27, 2025
@DL6ER DL6ER requested a review from a team February 27, 2025 05:05
This was referenced Feb 27, 2025
Open
Merged
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 27, 2025
View reviewed changes
@DL6ER DL6ER mentioned this pull request Feb 27, 2025
Open
@DL6ER
Copy link
Member Author

DL6ER commented Feb 27, 2025

Interesting, none of the AI-alerts is real, they were all of type:

grafik

but we do already check for exactly that:
grafik

yubiuser
yubiuser reviewed Feb 27, 2025
View reviewed changes
@DL6ER @yubiuser
PADD should show total CPU %
be30ef7 
Co-authored-by: yubiuser <[email protected]>
Signed-off-by: Dominik <[email protected]>
@yubiuser
Copy link
Member

Sorry, I think I made a mistake

https://github.com/pi-hole/PADD/blob/47bd6c68907ddaacd39a2f363f30a571162a8aea/padd.sh#L677

https://github.com/pi-hole/PADD/blob/47bd6c68907ddaacd39a2f363f30a571162a8aea/padd.sh#L463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yubiuser yubiuser yubiuser left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DL6ER @yubiuser