Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print values of env vars if they are invalid #2273

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 24, 2025

What does this implement/fix?

Print values of env vars if invalid, example:

ENV FTLCONF_dns_listeningMode = "not_existing"

leads to

2025-02-24 19:08:11.074 CET [2045070M] WARNING: ENV FTLCONF_dns_listeningMode = "not_existing" is not an allowed option, allowed options are: ["LOCAL","SINGLE","BIND","ALL","NONE"]

Related issue or feature (if applicable): Fixes #2262

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team February 24, 2025 18:10
@rdwebdesign rdwebdesign changed the title New/print invalid env Print values of env vars if they are invalid Feb 24, 2025
@PromoFaux
Copy link
Member

Looks to work as advertised. Is it intended that both the WARNING and the ERROR are printed?

image

yubiuser
yubiuser previously approved these changes Feb 24, 2025
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. But see Adams comment.

@DL6ER
Copy link
Member Author

DL6ER commented Feb 24, 2025

See my last commit :-)

@DL6ER DL6ER force-pushed the new/print_invalid_env branch from d821b07 to a5864de Compare February 24, 2025 20:13
@DL6ER DL6ER force-pushed the new/print_invalid_env branch from a5864de to 9857a18 Compare February 24, 2025 20:34
yubiuser
yubiuser previously approved these changes Feb 24, 2025
Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025-02-24_21-45

Copy link
Member

@yubiuser yubiuser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2025-02-24_22-03

@DL6ER DL6ER merged commit 0c91c17 into development Feb 24, 2025
19 checks passed
@DL6ER DL6ER deleted the new/print_invalid_env branch February 24, 2025 21:05
@PromoFaux
Copy link
Member

Ah - was just coming back to approve this, @yubiuser beat me to it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants