Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also make <domain> optional in the setupVars.conf migration process #2248

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 22, 2025

What does this implement/fix?

See title. This basically accepts that REV_SERVER_DOMAIN may be empty or unset. In this case, we do not make this domain part of the generated revServer configuration.


Related issue or feature (if applicable): #2216

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER added the Bugfix label Feb 22, 2025
@DL6ER DL6ER requested a review from a team February 22, 2025 10:32
@DL6ER DL6ER merged commit 4c4dd88 into development Feb 22, 2025
18 checks passed
@DL6ER DL6ER deleted the fix/revServer_migration branch February 22, 2025 10:59
@DL6ER DL6ER mentioned this pull request Feb 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants