Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow default GH token to write content in the build script #2200

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Feb 19, 2025

What does this PR aim to accomplish?:

We use https://github.com/softprops/action-gh-release to attach files to the release. They always needed content: write permission. So far this was not an issue, but the scope of the default GH token seems to have changed (softprops/action-gh-release#572 (comment)).
This PR grants the necessary permissions.

See a failing action trigged by a release tag here: https://github.com/pi-hole/FTL/actions/runs/13396405826


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team February 19, 2025 09:41
@DL6ER DL6ER merged commit 093c921 into development Feb 19, 2025
18 checks passed
@DL6ER DL6ER deleted the gh/permissions branch February 19, 2025 16:21
@PromoFaux PromoFaux mentioned this pull request Feb 20, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-post-release-fixes-and-findings/76480/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants