Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify teleporter zip verification #2198

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Feb 19, 2025

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/teleporter-v6-export-does-not-work/75905/4

@DL6ER DL6ER requested a review from a team February 19, 2025 16:32
@DL6ER DL6ER marked this pull request as ready for review February 19, 2025 16:32
@DL6ER
Copy link
Member Author

DL6ER commented Feb 19, 2025

It seems the miniz ZIP verification can be tricked. I have had process in the background creating ZIP files by steam and it errored out in about 1% of the tests. Even when it errored, the generated file was correct and I have checked this on the byte-level.

See also related https://discourse.pi-hole.net/t/teleporter-v6-export-does-not-work/75905/6

This should be good to go in.

@DL6ER DL6ER merged commit 3a7a992 into development Feb 19, 2025
19 checks passed
@DL6ER DL6ER deleted the fix/teleporter_zip_verify branch February 19, 2025 17:04
@PromoFaux PromoFaux mentioned this pull request Feb 20, 2025
@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/v6-post-release-fixes-and-findings/76480/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants