Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network table error handling #2097

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Oct 25, 2024

What does this implement/fix?

Go through network-table.c and ensure error handling is uniform, there were some cases in which an early returning caused by an error could have left prepared SQLite3 statements un-finalized. Whether this is the cause for occasional database locking we are seeing is unclear. However, the change

image

is specifically tailored to fix the cause of recently reported ERROR: add_netDB_network_address(-1, "192.168.0.168"): Failed to step (error 19): constraint failed messages.


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

…e were some cases in which an early returning caused by an error could have left prepared SQLite3 statements un-finalized. Whether this is the cause for occassional database locking we are seeing is unclear

Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER marked this pull request as ready for review October 26, 2024 19:12
@DL6ER DL6ER requested a review from a team October 26, 2024 19:12
@DL6ER DL6ER merged commit 68e493d into development Oct 26, 2024
19 checks passed
@DL6ER DL6ER deleted the tweak/network-table-error-handling branch October 26, 2024 20:03
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants