Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Civetweb Lua error reporting issue #2070

Merged
merged 11 commits into from
Sep 24, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Sep 23, 2024

What does this implement/fix?

This PR is largely analogous to civetweb/civetweb#1296. It adds the following extras specific to FTL:

  • Increase LUA string buffer size from 60 to 256 characters. This is necessary as most standard Pi-hole scripts (in the already lengths path "/var/www/admin/scripts/pi-hole/") would otherwise exceed the buffer size and be printed in an abbreviated form in stack tracebacks.
  • Load bundled scripts (to date, only inspect) in a better (more central) place where it is also imported for the web Lua environment.

Related issue or feature (if applicable): Fixes the issue discussed in pi-hole/web#3143

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team September 23, 2024 19:51
@DL6ER DL6ER mentioned this pull request Sep 23, 2024
5 tasks
@DL6ER DL6ER merged commit 001db49 into development Sep 24, 2024
19 checks passed
@DL6ER DL6ER deleted the fix/civetweb_lua_issue branch September 24, 2024 04:13
@DL6ER
Copy link
Member Author

DL6ER commented Oct 14, 2024

PR merged as is on CivetWeb repo: civetweb/civetweb#1296

@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants