-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettify BATS output #2044
Prettify BATS output #2044
Conversation
432b1cf
to
3e32c7a
Compare
d2187e3
to
c0e9504
Compare
Setting to draft mode. Not sure if |
1b7e1ae
to
2a015e4
Compare
Signed-off-by: yubiuser <[email protected]>
2a015e4
to
75f11f3
Compare
I've added a patch that will remove the double output on the CI log. I'll add the new dependencies to https://github.com/pi-hole/docker-base-images/blob/master/ftl-build/Dockerfile, point to the new tagged build container and remove the failing test after everything is done. |
Base image PR: pi-hole/docker-base-images#97 |
There is an issue with the base image (maybe it is a temporary issue):
|
@rdwebdesign Yes, the tag didn't exist. I did just publish it so we can try rebuilding in maybe an hour from now. |
This is the demo run with the new base image, containing one failing test on purpose. I'm going to remove the failing test and squash it down to two commits. Ready for review then. |
Signed-off-by: yubiuser <[email protected]>
cd84613
to
c83da0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this PR aim to accomplish?:
Adds color and nicer output to BATS
By submitting this pull request, I confirm the following:
git rebase
)