Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify BATS output #2044

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Prettify BATS output #2044

merged 2 commits into from
Sep 20, 2024

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Adds color and nicer output to BATS


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser force-pushed the pretty/bats branch 2 times, most recently from 432b1cf to 3e32c7a Compare August 26, 2024 18:57
@DL6ER
Copy link
Member

DL6ER commented Aug 26, 2024

Do you have an example screenshot for an error? At first glance, it isn't easier to read when everything works fine.

Your PR:
image

Some old action from last week:
image

@yubiuser
Copy link
Member Author

This is how it should look like (devcontainer in vscode)

Screenshot at 2024-08-26 20-57-28

@yubiuser yubiuser force-pushed the pretty/bats branch 4 times, most recently from d2187e3 to c0e9504 Compare August 26, 2024 20:06
@yubiuser
Copy link
Member Author

Setting to draft mode. Not sure if buildx in conjunction with githubs non-tty output can be tricked to show a nicer ouptut.

@yubiuser yubiuser marked this pull request as draft August 26, 2024 20:07
@yubiuser yubiuser changed the base branch from development-v6 to development September 2, 2024 21:44
@yubiuser yubiuser force-pushed the pretty/bats branch 5 times, most recently from 1b7e1ae to 2a015e4 Compare September 19, 2024 11:40
Signed-off-by: yubiuser <[email protected]>
@yubiuser
Copy link
Member Author

I've added a patch that will remove the double output on the CI log.

Currently, it looks like
2024-09-19_13-49


I'll add the new dependencies to https://github.com/pi-hole/docker-base-images/blob/master/ftl-build/Dockerfile, point to the new tagged build container and remove the failing test after everything is done.

@yubiuser
Copy link
Member Author

Base image PR: pi-hole/docker-base-images#97

@yubiuser yubiuser marked this pull request as ready for review September 19, 2024 19:11
@yubiuser yubiuser requested a review from DL6ER September 19, 2024 19:12
@rdwebdesign
Copy link
Member

There is an issue with the base image (maybe it is a temporary issue):

Error: buildx failed with: ERROR: failed to solve: ghcr.io/pi-hole/ftl-build:v2.8: failed to resolve source metadata for ghcr.io/pi-hole/ftl-build:v2.8: ghcr.io/pi-hole/ftl-build:v2.8: not found

@DL6ER
Copy link
Member

DL6ER commented Sep 19, 2024

@rdwebdesign Yes, the tag didn't exist. I did just publish it so we can try rebuilding in maybe an hour from now.

@yubiuser
Copy link
Member Author

This is the demo run with the new base image, containing one failing test on purpose.
https://github.com/pi-hole/FTL/actions/runs/10947390464/job/30417555607

I'm going to remove the failing test and squash it down to two commits. Ready for review then.

@yubiuser yubiuser requested a review from a team September 20, 2024 07:17
Copy link
Member

@DL6ER DL6ER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

on the last intentionally failing commit

@yubiuser yubiuser merged commit 23e614c into development Sep 20, 2024
19 checks passed
@yubiuser yubiuser deleted the pretty/bats branch September 20, 2024 11:15
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants