Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing validator for database.useWAL #1907

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Mar 12, 2024

What does this implement/fix?

#1773 recently added config validation enforcing every config option to have a validator assigned to it. After this PR was created, another #1868 added the new option database.useWAL which is now lacking such a validator, causing current development-v6 builds to fail the tests. This PR fixes this.

Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER merged commit ad06e92 into development-v6 Mar 12, 2024
15 checks passed
@DL6ER DL6ER deleted the fix/validate_useWAL branch March 12, 2024 20:30
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants