-
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow adlist duplicates #1886
Allow adlist duplicates #1886
Conversation
…ameter ?type={allow,block} Signed-off-by: DL6ER <[email protected]>
This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there: https://discourse.pi-hole.net/t/lists-cant-add-identical-url-twice-blocklist-allowlist/68261/12 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: DL6ER <[email protected]>
Conflicts have been resolved. |
Has been confirmed working on the related Discourse thread |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been confirmed working on the related Discourse thread
👍
Merge only once pi-hole/pi-hole#5572 and pi-hole/web#2958 are approved as well as these branches depend on each other |
What does this implement/fix?
Allow narrowing down the (ad)list type using the (optional) query parameter
?type={allow,block}
.Accompanying change related to pi-hole/pi-hole#5572. See reasoning therein.
This is a feature request submitted on Discourse (see link below).
Note
This pull requests requires all three Pi-hole components to be checked out
for testing
Related issue or feature (if applicable): N/A
Pull request in docs with documentation (if applicable): N/A
By submitting this pull request, I confirm the following:
git rebase
)Checklist:
developmental
branch.