Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print double newlines after invalid domains #1854

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Jan 7, 2024

Don't print double newlines after invalid domains.

  [i] Target: https://v.firebog.net/hosts/Easyprivacy.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 32268 exact domains and 0 ABP-style domains (blocking, ignored 5 non-domain entries)
      Sample of non-domain entries:
        - emam
        - smcom
        - smetriccom
        - smetrics.previcox.d
        - welcome..org


  [i] Target: https://v.firebog.net/hosts/Prigent-Ads.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 3700 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)

  [i] Target: https://raw.githubusercontent.com/FadeMind/hosts.extras/master/add.2o7Net/hosts
  [✓] Status: Retrieval successful
  [✓] Parsed 2030 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)

  [i] Target: https://raw.githubusercontent.com/crazy-max/WindowsSpyBlocker/master/data/hosts/spy.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 347 exact domains and 0 ABP-style domains (blocking, ignored 0 non-domain entries)

  [i] Target: file:///etc/pihole/test_list.txt
  [✓] Status: Retrieval successful
  [✓] Parsed 0 exact domains and 1 ABP-style domains (blocking, ignored 1 non-domain entries)
      Sample of non-domain entries:
        - com


  [✓] Building tree
  [i] Number of gravity domains: 354963 (352248 unique domains)


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from DL6ER January 7, 2024 21:26
@DL6ER DL6ER merged commit 7497937 into development-v6 Jan 8, 2024
16 checks passed
@DL6ER DL6ER deleted the no_double branch January 8, 2024 17:52
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants