Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pin SID to a specific IP address #1786

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Nov 27, 2023

What does this implement/fix?

A very simple change, see the title. This PR is the result of the discussion in #1779.

We furthermore fix a small wording issue and extend the description of the POST /auth API endpoint:

Screenshot from 2023-11-27 13-46-17

edit Updated screenshot


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@DL6ER DL6ER requested a review from a team November 27, 2023 12:42
@DL6ER DL6ER linked an issue Nov 27, 2023 that may be closed by this pull request
@DL6ER DL6ER force-pushed the tweak/session_no_ip branch from 64e9604 to 9cfb107 Compare November 27, 2023 12:45
Co-authored-by: yubiuser <[email protected]>
Signed-off-by: DL6ER <[email protected]>
@DL6ER DL6ER merged commit 8eef4d8 into development-v6 Dec 13, 2023
@DL6ER DL6ER deleted the tweak/session_no_ip branch December 13, 2023 18:46
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chrome may loose session
2 participants