Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

If Automod is installed, Show link after uninstall is complete #24

Closed
wants to merge 2 commits into from

Conversation

pertneer
Copy link

This adds a link in a success box, after uninstalling, to Automod tab in the acp if it is installed.

@marc1706
Copy link
Member

Please open a ticket in the MOD Team tools tracker so this can be properly discussed:
https://www.phpbb.com/bugs/modteamtools/

@michaelcullum
Copy link
Member

@@ -42,6 +42,7 @@
'ACTION' => 'Action',
'ADVANCED' => 'Advanced',
'AUTH_CACHE_PURGE' => 'Purging the Auth Cache',
'AUTOMOD' => 'Automod',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be "AutoMOD"

@marc1706
Copy link
Member

Users will want to go back to AutoMOD after installing a MOD, too. Therefore you should add that link to the header links right next to "Admin Index", etc. It should display that link on every UMIL page if AutoMOD is installed. This will also dramatically reduce the needed code.

@pertneer
Copy link
Author

Adding a link to all pages and adding this notification after uninstall are two different situations. Yes having a link on all pages would be handy, but I feel a notification that UMIL does not uninstall the MOD completely is still necessary. I have had a few people wonder why MODs were not uninstalled completely after the UMIL portion of the uninstall. It would better tie to two processes together.

@marc1706
Copy link
Member

marc1706 commented Feb 8, 2013

Pull request needs to be for the develop branch.

@pertneer
Copy link
Author

pertneer commented Feb 8, 2013

Can I change location of this pull request or do I need to create another for the development branch?

@marc1706
Copy link
Member

marc1706 commented Feb 9, 2013

I'm pretty sure you can't change the location. You'll have to open another for the develop branch. If you do, please close this one and refer to it in your new PR.

@pertneer
Copy link
Author

pertneer commented Feb 9, 2013

Changed location of request to development version #26

@pertneer pertneer closed this Feb 9, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants