Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Enable unary_operator_spaces fixer #851

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Enhancement: Enable unary_operator_spaces fixer #851

merged 2 commits into from
Dec 6, 2023

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Dec 5, 2023 •
edited
Loading

This pull request

  • enables the unary_operator_spaces fixer
  • runs make coding-standards

Follows #559.

💁‍♂️ For reference, see https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/blob/v3.40.2/doc/rules/operator/unary_operator_spaces.rst.

@kamil-tekiela
Copy link
Member

I think it's better with a space.

@localheinz localheinz mentioned this pull request Dec 5, 2023
Closed
2 tasks
@localheinz
Copy link
Contributor Author

@kamil-tekiela

See #853 as an alternative.

@Girgias
Copy link
Member

Girgias commented Dec 6, 2023

I think it's better with a space.

I disagree, and clearly the existing convention of the codebase is to not have a space.

@Girgias Girgias merged commit 1108131 into php:master Dec 6, 2023
2 checks passed
@localheinz localheinz deleted the feature/unary-operator-spaces branch December 6, 2023 08:35
@localheinz
Copy link
Contributor Author

Thank you, @Girgias and @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@localheinz @kamil-tekiela @Girgias