frankenphp-symfony: perf improvement #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
frankenphp/perf
branch
from
5af16bf to
8228dd0
Compare
| @@ -22,22 +22,25 @@ public function __construct(private HttpKernelInterface $kernel) | |||
|
|
|||
| public function run(): int | |||
| { | |||
| $kernel = $this->kernel; | |||
There was a problem hiding this comment.
Hmm, static function might not be worth it here since it has a reason to use $this.
There was a problem hiding this comment.
Yes I was hesitating but let's keep this simple indeed.
Co-authored-by: Francis Lavoie <[email protected]>
alexander-schranz
approved these changes
Oct 30, 2023
|
thx @dunglas |
alexander-schranz
pushed a commit
that referenced
this pull request
Oct 30, 2023
Tiny refactoring as suggested in #148 (comment)
Nyholm
pushed a commit
to php-runtime/frankenphp-symfony
that referenced
this pull request
Oct 30, 2023
Tiny refactoring as suggested in php-runtime/runtime#148 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of some micro-optimizations by @francislavoie laravel/octane#764 (comment)