Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to use the ENCODE-OBJECT/ENCODE-SLOTS protocol in ENCODE #67

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fiddlerwoaroof
Copy link

@fiddlerwoaroof fiddlerwoaroof commented Jan 13, 2022

Implements #66.

The current state of the library makes the incremental encoder a completely different world from ENCODE.
This makes it harder to extend YASON's encoding system because you have to override both ENCODE and
ENCODE-SLOTS.

@phmarek
Copy link
Owner

phmarek commented Jan 14, 2022

That's a bit too unspecific... Won't work for ratios, complex numbers, and so on.

How about adding a STANDARD-OBJECT qualification? Does that code also work for structures?
Please include a test as well.

Thanks for the idea!

@phmarek
Copy link
Owner

phmarek commented Feb 14, 2022

Did you mean to change anything? I can't see any difference in the diff.

Can you add an example or at least a test as well, please?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants