Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Guard for nil request when getting fragments #171

Merged
merged 2 commits into from
Mar 19, 2024
Merged

fix: Guard for nil request when getting fragments #171

merged 2 commits into from
Mar 19, 2024

Conversation

joelmoss
Copy link
Contributor

fixes #170

willcosgrove
willcosgrove approved these changes Mar 19, 2024
View reviewed changes
Copy link
Collaborator

@willcosgrove willcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This will also be important for any kind of rendering done outside of the request/response cycle, like in a background job.

@joeldrapper joeldrapper merged commit 5ebe4d9 into phlex-ruby:main Mar 19, 2024
13 checks passed
@joelmoss joelmoss deleted the guarded_request branch March 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willcosgrove willcosgrove willcosgrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use as email template failing due to nil view_context.request
3 participants
@joelmoss @willcosgrove @joeldrapper