New version of rake (12.3.2) broke the build #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've tested your project with an updated dependency and the build failed.
This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.
Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.
If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)
We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of rake for this test run.
What changed?
✳️ rake ( → 12.3.2) · Repo · Changelog
Commits
See the full diff on Github. The new version differs by 41 commits:
Bump version to v12.3.2Merge pull request #297 from ruby/ignore-warnings-2.6Fixed warnings with https://bugs.ruby-lang.org/issues/15231Merge pull request #293 from colby-swandale/colby/rdoc-improvementsMerge pull request #294 from colby-swandale/colby/update-public-clone-urlMerge pull request #295 from colby-swandale/colby/improve-contributing-docimprove running test instructions and denote commands with `$`update public clone URL to use httpsignore all test classes in rdocadd missing params to `task` call-seq examples to match consistencyset Application#set_default_options to be ignored by rdocMerge pull request #289 from colby-swandale/colby/prevent-multiple-coveralls-commentsMerge pull request #291 from colby-swandale/colby/update-jrubyupdate jruby to the latest version in travisMerge pull request #273 from jsm/masterImprove multitask performanceMerge pull request #288 from colby-swandale/colby/fix-readme-linksMerge pull request #290 from colby-swandale/update-jrubyupdate latest jruby version in travisrun coveralls only when COVERALLS env var is presentfix links to rake resources not showing on GithubMerge pull request #287 from colby-swandale/rework-invalid-task-error-messageMerge pull request #285 from colby-swandale/colby/add-rubocop-to-contributingRework the error message that tells to list the tasks with `rake --tasks`add rubocop section to CONTRIBUTING.rdocMerge pull request #280 from colby-swandale/add-dev-binstubsMerge pull request #282 from colby-swandale/colby/fix-rubocopfix errors in rubocopadd binstubs for bundler, rake, rodc and rubocopMerge pull request #278 from aycabta/use-ruby-2.5.3Use Ruby 2.2.10, 2.3.8, 2.4.5, and 2.5.3Merge pull request #275 from zhustec/masterMerge pull request #276 from felixonmars/patch-1Remove more space after `!` operatorFix a typo in lib/rake/application.rbremove trailing extension name in requireMerge pull request #265 from jeremyevans/jruby92-fixMerge pull request #268 from take-cheeze/prereqs_aliasAdd alias `prereqs`.Use simpler RUBY_PLATFORM check for java in cpu_counter.rbFix JRuby detection on JRuby 9.2 in cpu_counter.rbDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands