-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local deploy commands should run on release-branches/ #401
Comments
@samreid and @jonathanolson and I had a conversation today about this in regards to #363. Ideally we were trying to brainstorm a simple and cheap way to get rid of We do not, at this time, recommend trying to remove the dependency we have on perennial-alias. Through this though, we do feel like recognizing a shift in perennial's design, where we don't prefer git commands on the main checkout, and first see if it is an implementation detail that can be hidden in Let's experiment with using ReleaseBranch() for Also, @jonathanolson had an idea that this could be a stepping stone for having a class Repo{
string pathToRoot;
string name;
async checkoutSHA(){}
async checkoutMain(){}
async checkoutBranch(){}
async pull(){}
async status(){}
}
class Checkout{
string pathToRoot;
dependencies: Record<RepoName,Repo>
checkoutShas(){}
update(){} // clone/checkout/npm/etc
}
class ReleaseBranch extends Checkout{
repo: string;
branch: string;
build(){}
} |
From #363, @samreid @jonathanolson and I had an idea to try to get rid of the need for perennial-alias by using the release-branches/ strategy used by maintenance tooling and the build server. The general goal of this would be to one day have no perennial build commands that require changing shas in the main checkout, but that seems like a giant project, and so we just want to experiment.
The commands that feel most important to change (to MK) are:
We have scheduled a meeting to investigate for next tuesday.
The text was updated successfully, but these errors were encountered: