-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It is complex, confusing and inefficient to have perennial and perennial-alias #363
Comments
One solution to this problem may be: Discovered in phetsims/chipper#1464 One idea @jonathanolson and @zepumph and I discussed is:
perennial-alias has been a point of complexity and confusion, and would be good to eliminate. We discussed that developers could have one working copy which is always on main, and another which is allowed to operate on shas, branches, etc. However, this would: I just wanted to write the idea down, knowing that it is likely too expensive to implement. But it is the first viable alternative to perennial-alias that we have considered, which would also allow perennial to use code from phet-core or axon, etc. |
@jonathanolson and @samreid and I spoke about this again today, and we want to gather more information by investigating #401. From here we can learn if having a codebase where "all branches are always on main while executing perennial commands" is possible. |
One path forward that @samreid and I just thought of is to center all of our code around perennial-alias. |
We spend 2 hours brainstorming with @jonathanolson over in #401 (comment) and didn't find a better solution that perennial-alias. All other ideas would require lots of work to change things, but then (mostly) still have trade offs and challenges for maintenance, deploys, and developer training. We are ready to close this issue and continue with perennial-alias indefinitely. |
It is complex, confusing and inefficient to have perennial and perennial-alias. Now that we have more functionality in perennial (linting, grunt tasks, node modules) this problem is increased.
Each time a developer needs to make a change in perennial, they need to think carefully about whether to change the copy in perennial or perennial-alias. Then after making the change, and pushing, they need to be careful to pull the other repo. When a change is needed in both, the developer must take care not to push both.
The text was updated successfully, but these errors were encountered: