Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nodejs, requirejs, commonjs code intelligence integration #602

Merged
merged 1 commit into from
Aug 7, 2022
Merged

feat: nodejs, requirejs, commonjs code intelligence integration #602

merged 1 commit into from
Aug 7, 2022

Conversation

abose
Copy link
Member

@abose abose commented Aug 7, 2022 •
edited
Loading

Jump to definition and codehints now works from requirejs contexts

Testing

  • All unit tests passing as before
  • Verified manually that jump to def and codehints is working on bracktes project src, sample node module project, es6 project

known issues

#601

@phoenixide
Copy link
Member

Thank You for making this pull request.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abose abose merged commit e5c6010 into main Aug 7, 2022
@abose abose deleted the req branch August 7, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abose @phoenixide