-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PhStore: unified persistant storage in browser and tauri #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Thank You for making this pull request. |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 3 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localstorage and indexed db is not guarenteed to be persistant in desktop builds. Specifically, webkit will nuke the stored data in linux/mac tauri builds as part of ITP. We save a few of data into local storage like some preferences, so this will be a concern if a user comes back after some time and uses the app.
After this change, we now have a global
PhStore
object with the below API that can be used in all platforms. The storage layer is synchronous for get and put operations. This is not supposed to be used directly, but indirectly in phoenix via a future phoenix.getModule.